chore: improve DML check

betodealmeida commented 1 month ago

SUMMARY

Small improvement: only check for DDL/DML in SQL Lab when the feature is disabled in the DB. This way we don't need to parse the query unnecessarily.

Also bump sqlglot.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
[ ] Introduces new feature or API
[ ] Removes existing feature or API

michael-s-molina commented 1 month ago

@betodealmeida Can you add the sqlglot CHANGELOG to the PR description to help reviewers?

michael-s-molina commented 1 month ago

@betodealmeida I noticed that there are many breaking changes between 23.0 and 25.24. Can any of these affect us?

betodealmeida commented 1 month ago

@betodealmeida I noticed that there are many breaking changes between 23.0 and 25.24. Can any of these affect us?

As far as I can tell, no. The breaking changes are either breaking internal APIs (which we don't rely heavily on), or breaking behavior that was previously incorrect.

apache / superset