apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
62.29k stars 13.67k forks source link

SQL_MAX_ROW > 100000 - get error Maximum call stack size exceeded #30533

Open lndigoIife opened 1 week ago

lndigoIife commented 1 week ago

Bug description

  1. Set SQL_MAX_ROW to a constant value other than 100,000.
  2. Create a table that returns more than 100,000 rows from SQL, for example 250,000.
  3. Set a value exceeding 100,000, for example 300,000.
  4. Save and look at the table on the dashboard
  5. Data collection location: An error occurred when displaying the visualization: RangeError: The maximum size of the call stack has been exceeded

Screenshots/recordings

1 2

Superset version

4.0.2

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

dosubot[bot] commented 1 week ago

Hey @lndigoIife, I'm here to help you with this bug report. I'm a bot designed to assist with bug fixes, answer questions, and guide you to become a contributor. Let's work together to resolve this issue.

I found a similar closed issue regarding the row limit being hardcoded at 100,000 in the UI. This issue was resolved by a pull request that fixed the hardcoded row limit [1]. However, the specific changes made in the pull request and how they relate to the "Maximum call stack size exceeded" error are not detailed in the available information.

To address the "Maximum call stack size exceeded" error, you might want to consider the following:

  1. Optimize Query Performance: Ensure that your database can handle large queries efficiently. This might involve indexing, query optimization, or using materialized views.

  2. Adjust Configuration Settings: Check if there are any configuration settings related to memory or stack size that can be adjusted to better handle large datasets.

  3. Limit Data Processed: Consider reducing the number of rows processed at once or using pagination to handle large datasets more effectively.

These steps can help mitigate issues when working with large datasets in Superset.

To continue talking to Dosu, mention @dosu.