search

apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
62.95k stars 13.93k forks source link

List Roles: Action icon not displayed #30639

Open praveer38 opened 1 month ago

praveer38 commented 1 month ago

Screenshot

image

Description

On the List Roles page, there seems to be an icon in the “Actions” button that is not being displayed correctly.

dosubot[bot] commented 1 month ago

The issue with the icon not being displayed correctly in the "Actions" button on the List Roles page might be related to the CSS styles applied to the button. The StyledActions and ActionWrapper components define styles that could affect the icon's visibility. Specifically, the svg and i elements have a margin-right of 8px, and on hover, the path within these elements changes its fill color to the theme's primary base color. Additionally, the text color is set to the theme's grayscale base color, which might cause visibility issues if the theme's colors are similar to the background [1].

To address this, you might want to check the theme's color settings and ensure they provide enough contrast for the icons to be visible. Additionally, verify that the icon libraries @react-icons/all-files and @ant-design/icons are correctly installed and configured, as these are used for rendering icons in Apache Superset [2][3][4].

To continue talking to Dosu, mention @dosu.

rusackas commented 2 weeks ago

Valid, but this view needs to be converted from a FAB view (Python/Jinja template) to a React view. This isn't likely to get prioritized, but we're happy to review a PR!

samarsrivastav commented 2 weeks ago

Hey @rusackas , would love to work on this bug

rusackas commented 2 weeks ago

Hey @rusackas , would love to work on this bug

Fantastic, go for it!