apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
62.38k stars 13.7k forks source link

No Python 3.11 images on DockerHub #30672

Open padbk opened 2 hours ago

padbk commented 2 hours ago

Bug description

I note that Superset 4.1.0rc3 supports python 3.11 https://github.com/apache/superset/blob/03b72628fabe3d5277e95c387c7450898acbab53/pyproject.toml#L35

But there are no images on Dockerhub that use 3.11: https://hub.docker.com/r/apache/superset/tags?name=py311

The docker build script seems to contain the logic to create a 3.11 image: https://github.com/apache/superset/blob/03b72628fabe3d5277e95c387c7450898acbab53/scripts/build_docker.py#L152

But I don't think this script is being run by the machine that is pushing the images to Dockerhub?

Screenshots/recordings

No response

Superset version

master / latest-dev

Python version

3.11

Node version

Not applicable

Browser

Not applicable

Additional context

No response

Checklist

dosubot[bot] commented 2 hours ago

The issue you're encountering might be due to the build_docker.py script not being triggered or executed in the CI/CD pipeline responsible for pushing images to Docker Hub. While the script does contain logic for building Python 3.11 images, there might be missing configurations or triggers in the CI/CD setup that prevent it from running.

The CI/CD setup for Apache Superset uses GitHub Actions to build and push Docker images. However, specific triggers or configurations for executing the build_docker.py script, especially for the Python 3.11 images, might not be correctly set up or documented [1].

Additionally, ensure that the necessary environment variables, such as DOCKERHUB_USER and DOCKERHUB_TOKEN, are set, as these are required for authentication to push images [2]. You might want to check the GitHub Actions workflows, particularly the docker.yml file, to verify if the py311 build preset is included in the build matrix or if there are any conditions that might prevent its execution.

To continue talking to Dosu, mention @dosu.

padbk commented 2 hours ago

I've had a look in Github Actions, but can't see what needs to be changed. Please can someone more familiar with GHA take a look 🙏