chore(Accessibility): Fix accessibility for 'Show x entries' dropdown in tables

LevisNgigi commented 2 weeks ago

SUMMARY

This PR addresses an accessibility issue in the table charts component of Apache Superset. The 'Show x entries' dropdown lacked proper form control labeling, which is essential for screen reader users. The label has been updated to ensure that it provides a clear and descriptive indication of its purpose, improving the overall accessibility of the feature.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Per page superset

TESTING INSTRUCTIONS

Navigate to a table chart in Apache Superset.
Locate the 'Show x entries' dropdown.
Use a screen reader (e.g., NVDA or VoiceOver) to navigate to the dropdown.
Verify that the screen reader announces the label correctly as "Show [number] entries," where [number] is the selected value.

ADDITIONAL INFORMATION

[x] Has associated issue: Fixes #30669
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
[ ] Introduces new feature or API
[ ] Removes existing feature or API

geido commented 1 week ago

Hello @LevisNgigi you have a conflicting package-lock which I believe should not be there in the first place. Can you remove it?

From re-reading the issue description, it also seems that the goal was to make also the number of entires accessible, so that the label should read "Show X entries per page". Can we fix that?

Thank you!

LevisNgigi commented 1 week ago

Hello @LevisNgigi you have a conflicting package-lock which I believe should not be there in the first place. Can you remove it?

From re-reading the issue description, it also seems that the goal was to make also the number of entires accessible, so that the label should read "Show X entries per page". Can we fix that?

Thank you!

Yes I can remove it. Not sure how it appeared after fixing the lint issue. I have made changes. I have also deleted the package-lock file.

geido commented 1 week ago

I still see the package-lock though. I think you can just get it from master and replace it locally so it matches.

LevisNgigi commented 1 week ago

I still see the package-lock though. I think you can just get it from master and replace it locally so it matches.

Should be fixed now.

rusackas commented 1 week ago

Running CI :)

geido commented 3 days ago

/testenv up

github-actions[bot] commented 3 days ago

@geido Ephemeral environment spinning up at http://35.95.64.64:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

apache / superset