apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
62.91k stars 13.91k forks source link

chore(oauth2): enable user impersonation by default #30983

Open betodealmeida opened 2 days ago

betodealmeida commented 2 days ago

SUMMARY

When configuring a database, if the user provides OAuth2 client information (ID and secret) then we should automatically enable user impersonation for them.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

WIP

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

villebro commented 21 hours ago

Is user impersonation really needed for OAuth? I would have assumed OAuth mostly makes user impersonation redundant, as you already have full user-specific authentication in place (no need for a service account).