Empty lists on Welcome screen after upgrade to 0.28.1

apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform

https://superset.apache.org/

Apache License 2.0

62.68k stars 13.84k forks source link

Empty lists on Welcome screen after upgrade to 0.28.1 #6214

Closed wowo closed 6 years ago

wowo commented 6 years ago

Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if any
[x] I have reproduced the issue with at least the latest released version of superset
[x] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.28.1

Expected results

After upgrade to Superset 0.28.1 (from 0.27.0) via Pip, there's nothing on welcome screen (dashboards, recently viewed, favourites), although I have for instance 3 favourites and I see they are being returned via Ajax call (Google Developer Tools). Happens in firefox and chrome.

2018-10-29_0850 2018-10-29_0851_001

mistercrunch commented 6 years ago

@williaster I think this may be related to your recent SupersetClient refactor.

williaster commented 6 years ago

@mistercrunch are you saying that because you've you've debugged it and you can see that it's related to my changes?

I think this is actually due to broken reactable version. Basically we can either have a version that works in Prod, or one that works in Dev, but not both. Maybe 28.1 was cut with a version that only works for Dev? See #6142.

cc @kristw

mistercrunch commented 6 years ago

@williaster to be honest I have no evidence it's due to SupersetClient just operating on intuition here.

0.28 was cut without much testing as an emergency fix to 0.27 that started failing (due to unpinned dependencies), and knowing that it would be a while before we'd come up with a proper Apache release.

kristw commented 6 years ago

I am confident this is due to reactable. I first increased the version because this behavior happens in development. Then found that it fixes dev but breaks prod so I reported an issue (#5935). A few weeks ago I downgraded reactable to make sure production works (#6142).

williaster commented 6 years ago

^That's consistent with my experience, production works right now and for dev you have to manually change the version for it to work locally.

wowo commented 6 years ago

I've downloaded repo from master, build assets and used them with 0.28.1 (with reactable on 1.0.02) and it works fine

mistercrunch commented 6 years ago

So we have no reactable version that work in both cases? :(

kristw commented 6 years ago

@mistercrunch Nope. There is an opened issue about this on the reactable repo itself and I have commented on it a month ago. The maintainer acknowledged, but there has been no update since. We'd better migrate to something else IMHO.

williaster commented 6 years ago

sorry about the trouble @wowo, glad you found a workaround.

I agree we should move away from this one, @kristw has noted that there are ~10 components that use this lib now, so it's not super easy.

we could look into how hard it is to install different versions depending on dev vs prod to take away some of the urgency?

mistercrunch commented 6 years ago

Which specific Reactable issue is the blocker? Is it related to react-hot-loader?

kristw commented 6 years ago

@mistercrunch It seems related to react 16 https://github.com/abdulrahman-khankan/reactable/issues/3