apache / superset

Apache Superset is a Data Visualization and Data Exploration Platform
https://superset.apache.org/
Apache License 2.0
61.44k stars 13.4k forks source link

[SIP-63] Incorporating other map sources in Superset #9281

Closed gk1089 closed 7 months ago

gk1089 commented 4 years ago

[SIP] Proposal for Incorporating other map sources in Superset

Motivation

Superset currently uses MapBox to display maps which has its own limitations. There are other map sources available as Web Map Services (WMS). For example, Open Street Maps (OSM) that can be called upon using many js libraries like Leaflet or OpenLayers. This would pave way for more GIS functionalities in SuperSet in true open source spirit.

Later, the same could also apply to the deck,gl visualizations that simply use mapbox for its simplicity.

Proposed Change

Module can be created that permit adding WMS services during the creation of charts. Other features may include:

  1. Adding multiple layers and providing facility to turn them on/off.
  2. Permitting clicking on features (points) to show a popup with more data/links on the map itself.

New or Changed Public Interfaces

Same as described above.

New dependencies

Leaflet (https://www.npmjs.com/package/leaflet) and OpenLayers (https://www.npmjs.com/package/ol)

Migration Plan and Compatibility

Should work with existing setup.

Rejected Alternatives

I am proposing considering the open data sources right now. So, no Google/Bing maps etc.

Describe alternative approaches that were considered and rejected.

I would like to attempt this but I am really at a loss for where to begin with implementing it. I have seen discussions about new chart types here and although the documentation is old regarding that, some of the issue threads provide pointers in the right direction.

I intend this thread to be something of the same kind where some of the developers may point us to the right section of the code where we can begin exploring and implementing open source mapping visualizations.

I hope the developers see some merit in it.

rusackas commented 7 months ago

Looking forward to merging that cartodiagram! In the meantime, this SIP itself has gone dormant in terms of official consensus activity (proposed for Discussion in 2021 with no replies since). The original author doesn't seem to be here to put it to a vote. According to a recently voted process, we'll close this out as stale. If someone wishes to rekindle this effort, I think we should take the most important bits into a fresh SIP and start the process anew.