search

apache / trafficcontrol

Apache Traffic Control is an Open Source implementation of a Content Delivery Network
https://trafficcontrol.apache.org/
Apache License 2.0
1.06k stars 340 forks source link

TP - empty value field for parameter not accepted #2397

Closed ezelkow1 closed 6 years ago

ezelkow1 commented 6 years ago

With the old TO UI we do currently have parameters that have/use empty value fields, i.e. various ATS plugins. These were valid in the TO ui but if you open them now are invalid the TP UI. This also prevents you from adding a new parameter that is similar to these

mitchell852 commented 6 years ago

To achieve this in TP:

  1. remove the API validation on "Value:

https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/parameter/parameters.go#L102

  1. remove the 'required' attribute from TP

https://github.com/apache/trafficcontrol/blob/master/traffic_portal/app/src/common/modules/form/parameter/form.parameter.tpl.html#L55