search

apache / trafficcontrol

Apache Traffic Control is an Open Source implementation of a Content Delivery Network
https://trafficcontrol.apache.org/
Apache License 2.0
1.08k stars 344 forks source link

Fix Traffic Monitor to not require `health.polling.url` if poll type is noop #2683

Open rob05c opened 6 years ago

rob05c commented 6 years ago

If health.polling.format and health.polling.type are noop, the health.polling.url isn't used, and therefore shouldn't be required.

But it isn't trivial to do right, because the monitorconfig manager which currently errors if the url doesn't exist, doesn't know what a noop poller is, or anything about poller or format types.

So, we'll probably need to push that error down to the poller. And figure out how to do so, while still erroring in an appropriate place, and flagging the cache as polled-but-unavailable so the service starts.

mitchell852 commented 3 years ago

@rob05c can you put a severity label on this bug? minor, medium, major or critical?