search

apache / trafficcontrol

Apache Traffic Control is an Open Source implementation of a Content Delivery Network
https://trafficcontrol.apache.org/
Apache License 2.0
1.03k stars 339 forks source link

Add Monitoring.json to Snapshot Diff #3395

Open rob05c opened 5 years ago

rob05c commented 5 years ago

The monitoring.json is snapshotted with the CDN CRConfig.json Snapshot now.

This should be added to Traffic Portal, in the CDN Snapshot diff.

This may also require a "raw monitoring.json" or "get monitoring.json JSON PATCH diff" endpoint be added to Traffic Ops.

mitchell852 commented 4 years ago

TP diffs the CRConfig.json snapshot by calling 2 api endpoints:

GET /api/cdns/{cdn}/snapshot <-- current snapshot
GET /api/cdns/{cdn}/snapshot/new <-- what the snapshot will look like after a snapshot action is performed

For monitoring I see:

GET api/cdns/{cdn}/configs/monitoring

So maybe an endpoint like this is needed?

GET api/cdns/{cdn}/configs/monitoring/new

and then it would be simple enough to add it to snapshot diff section of TP.

mitchell852 commented 3 years ago

let's revisit this once this blueprint is resolved: #5367