apache / trafficcontrol

Apache Traffic Control is an Open Source implementation of a Content Delivery Network
https://trafficcontrol.apache.org/
Apache License 2.0
1.08k stars 344 forks source link

Steering endpoint is accessible to a user that doesn't have steering role. #3886

Closed lbathina closed 5 years ago

lbathina commented 5 years ago

I'm submitting a ...

Traffic Control components affected ...

Current behavior:

use ort user or any user that has access privilege less than the steering user to request /api/<version>/steering/{{id}} api/<version>/steering/{{id}}/targets The response got is 200 OK

Expected / new behavior:

It makes more sense to give HTTP 403 Forbidden with error text something like You don't have permission for this action/method with your role

Minimal reproduction of the problem with instructions:

Anything else:

Response for steering Endpoint should indicate appropriate status code and message

lbathina commented 5 years ago

Guess this will not be bug as well. edit/delete operations are not allowed as expected. However, the PR #3507 did not clearly mention about the view access or access to get actions.