apache / trafficcontrol

Apache Traffic Control is an Open Source implementation of a Content Delivery Network
https://trafficcontrol.apache.org/
Apache License 2.0
1.07k stars 344 forks source link

'admin' tool should use pq #4954

Open ocket8888 opened 4 years ago

ocket8888 commented 4 years ago

I'm submitting a ...

Traffic Control components affected ...

Current behavior:

admin shells out to subprocess using a psql binary` for database operations.

Expected / new behavior:

The admin tool should use a postgresql adapter to make database connections instead of relying on shelling out to a psql binary somewhere in the system's path. That'd make database errors more transparent (I'm currently getting the extremely helpful error message "unable to determine if user already exists: exit status 2"), and would eliminate the dependency on the postgresql client.

MylesBock commented 3 years ago

I think I have something that could end up solving this, may I be assigned this issue?