search

apache / trafficcontrol

Apache Traffic Control is an Open Source implementation of a Content Delivery Network
https://trafficcontrol.apache.org/
Apache License 2.0
1.03k stars 339 forks source link

TP servers page: quick filter should only apply to currently viewed colums. #5432

Open traeak opened 3 years ago

traeak commented 3 years ago

I'm submitting a ...

Traffic Control components affected ...

Current behavior:

The "quick search" box filters on all columns, not just the columns currently selected for display.

New behavior:

The "quick search" box should only apply to columns currently selected for viewing.

Minimal reproduction of the problem with instructions:

During an upgrade I took a batch of machines to admin_down with reason that included a substring of the new profile. With the "offline reason" column turned off (not being viewed), quick search for that new profile substring. quick search results include not only servers on the new profile but also also all the servers with the "offline reason" with the new profile.

Anything else:

mitchell852 commented 3 years ago

yeah, it can be confusing when you get matches on data that has been hidden. fyi - this applies to any TP table that uses the ag-grid: servers, ds requests, jobs, etc.