apache / trafficcontrol

Apache Traffic Control is an Open Source implementation of a Content Delivery Network
https://trafficcontrol.apache.org/
Apache License 2.0
1.02k stars 339 forks source link

Updating a DS w/ consistent hash query params creates unrelated change log message #5618

Open mitchell852 opened 3 years ago

mitchell852 commented 3 years ago

I'm submitting a ...

Traffic Control components affected ...

Current behavior:

Create a new HTTP delivery service and give it one consistent hash query parameter. Now, update the delivery service (change the display name for example). For some reason, the following API change log message is being recorded.

image

Expected behavior:

Only if a delivery service consistent hash query parameter was actually deleted should that message be recorded. Actually, i think we decided that creating/updating/deleting ds consistent hash query parameters should never create a change log entry...period.

Minimal reproduction of the problem with instructions:

See current behavior.

srijeet0406 commented 3 years ago

Should already be fixed in https://github.com/apache/trafficcontrol/pull/5410

rawlinp commented 3 years ago

The Deleted N consistent hash query params changelog message is still an issue.