search

apache / trafficcontrol

Apache Traffic Control is an Open Source implementation of a Content Delivery Network
https://trafficcontrol.apache.org/
Apache License 2.0
1.07k stars 344 forks source link

DSR "fulfill" context menu item has no purpose #6155

Open ocket8888 opened 3 years ago

ocket8888 commented 3 years ago

This Bug Report affects these Traffic Control components:

Current behavior:

Clicking on "Fulfill Request" in the context menu on a DSR in the table just takes you to the DSR's details page, doesn't fulfill the request.

Expected behavior:

Clicking on "Fulfill Request" should fulfill the request.

Steps to reproduce:

  1. Create a DSR (any kind)
  2. Go to the TP DSRs table page
  3. Right-click on the DSR, opening the context menu
  4. Click on "Fulfill Request" from the menu.
mitchell852 commented 3 years ago

actually that's how it's always been. it takes you to the details page where you have to then click "fulfill request". i'm going to change this to an "improvement". the idea being that you should first look at the change before fulfilling.

ocket8888 commented 3 years ago

I could swear I actually fulfilled one that way before. But if you say so

mitchell852 commented 3 years ago

honestly, do we want people fulfilling from the context menu where they have no idea of what changes they are fulfilling? i say no. i would close this.

ocket8888 commented 3 years ago

Maybe, but if that context menu item isn't different than just clicking on the row, then why does it exist at all?

mitchell852 commented 3 years ago

Maybe, but if that context menu item isn't different than just clicking on the row, then why does it exist at all?

good question. maybe that's what this issue should do - remove the "fulfill" context menu item.

mitchell852 commented 2 years ago

good question. maybe that's what this issue should do - remove the "fulfill" context menu item.

@ocket8888 - you ok with that solution? ^^

ocket8888 commented 2 years ago

Yes