search

apache / trafficcontrol

Apache Traffic Control is an Open Source implementation of a Content Delivery Network
https://trafficcontrol.apache.org/
Apache License 2.0
1.02k stars 339 forks source link

TPv2: Update required node version to >= 18, eslint-plugin-jsdoc #7933

Closed ntheanh201 closed 4 months ago

ntheanh201 commented 4 months ago

Closes: #7932

## Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

ntheanh201 commented 4 months ago

I also believe that our current eslint-plugin-jsdoc is not working correctly, when we run: "npm run lint" the current version eslint-plugin-jsdoc it doesn't show any error about missing jsdoc from functions. After I updated the package, it shows the error when run lint

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2190789) 31.75% compared to head (2dcfa4b) 65.66%. Report is 85 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #7933 +/- ## ============================================= + Coverage 31.75% 65.66% +33.90% Complexity 98 98 ============================================= Files 717 323 -394 Lines 82786 12840 -69946 Branches 970 970 ============================================= - Hits 26289 8431 -17858 + Misses 54339 4050 -50289 + Partials 2158 359 -1799 ``` | [Flag](https://app.codecov.io/gh/apache/trafficcontrol/pull/7933/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [golib_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [grove_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [t3c_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [traffic_monitor_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [traffic_ops_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [traffic_portal_v2](https://app.codecov.io/gh/apache/trafficcontrol/pull/7933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.39% <ø> (+0.01%)` | :arrow_up: | | [traffic_stats_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unit_tests](https://app.codecov.io/gh/apache/trafficcontrol/pull/7933/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.39% <ø> (+45.32%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.