search

apache / trafficcontrol

Apache Traffic Control is an Open Source implementation of a Content Delivery Network
https://trafficcontrol.apache.org/
Apache License 2.0
1.02k stars 339 forks source link

TPv2 lint fixes #7937

Closed ocket8888 closed 4 months ago

ocket8888 commented 4 months ago

This PR fixes new linting errors that have arisen from #7933 .

I also fixed one typo in markup, fixed a couple of call signature mismatches between the concrete and testing Delivery Service API services, and did some spelling/grammar changes in JSDoc comment blocks of some API service methods.

Also, rather than fix the CoordinateService, I removed it, since it only had one method, which already existed on the CacheGroupService.

Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

Make sure the linter now passes, and that all existing tests still pass after the removal of the CoordinateService.

PR submission checklist

codecov[bot] commented 4 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a01d4af) 65.78% compared to head (69b9367) 65.75%. Report is 2 commits behind head on master.

Files Patch % Lines
...al/src/app/api/testing/delivery-service.service.ts 33.33% 2 Missing and 2 partials :warning:
...-portal/src/app/api/testing/cache-group.service.ts 0.00% 2 Missing :warning:
...affic-portal/src/app/api/testing/origin.service.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #7937 +/- ## ============================================ - Coverage 65.78% 65.75% -0.03% Complexity 98 98 ============================================ Files 329 327 -2 Lines 13038 13010 -28 Branches 1001 998 -3 ============================================ - Hits 8577 8555 -22 + Misses 4100 4091 -9 - Partials 361 364 +3 ``` | [Flag](https://app.codecov.io/gh/apache/trafficcontrol/pull/7937/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [traffic_portal_v2](https://app.codecov.io/gh/apache/trafficcontrol/pull/7937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.35% <30.00%> (-0.03%)` | :arrow_down: | | [unit_tests](https://app.codecov.io/gh/apache/trafficcontrol/pull/7937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.35% <30.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.