apache / trafficcontrol

Apache Traffic Control is an Open Source implementation of a Content Delivery Network
https://trafficcontrol.apache.org/
Apache License 2.0
1.02k stars 339 forks source link

Fix incorrect display of delivery services for an ORG server #7957

Closed rimashah25 closed 3 months ago

rimashah25 commented 3 months ago

## Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

Run TO and TP List the delivery services assigned to an ORG server Only those DS's should show up that are present in the deliveryservice_server table

Do the same test for other types of servers, and make sure that topologies and required_capabilities are respected

If this is a bugfix, which Traffic Control versions contained the bug?

8.0.0

PR submission checklist

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 29.23%. Comparing base (dc995a9) to head (e9ab617). Report is 1 commits behind head on master.

Files Patch % Lines
...ffic_ops_golang/deliveryservice/servers/servers.go 0.00% 17 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #7957 +/- ## ============================================ + Coverage 26.29% 29.23% +2.94% Complexity 98 98 ============================================ Files 738 859 +121 Lines 85719 91276 +5557 Branches 90 998 +908 ============================================ + Hits 22537 26683 +4146 - Misses 61094 62439 +1345 - Partials 2088 2154 +66 ``` | [Flag](https://app.codecov.io/gh/apache/trafficcontrol/pull/7957/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [golib_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.93% <ø> (ø)` | | | [grove_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.60% <ø> (ø)` | | | [t3c_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.82% <ø> (ø)` | | | [traffic_monitor_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `20.67% <ø> (ø)` | | | [traffic_ops_integration](https://app.codecov.io/gh/apache/trafficcontrol/pull/7957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `69.42% <ø> (ø)` | | | [traffic_ops_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.54% <0.00%> (+0.04%)` | :arrow_up: | | [traffic_portal_v2](https://app.codecov.io/gh/apache/trafficcontrol/pull/7957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.36% <ø> (?)` | | | [traffic_stats_unit](https://app.codecov.io/gh/apache/trafficcontrol/pull/7957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `10.16% <ø> (ø)` | | | [unit_tests](https://app.codecov.io/gh/apache/trafficcontrol/pull/7957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.52% <0.00%> (+3.38%)` | :arrow_up: | | [v3](https://app.codecov.io/gh/apache/trafficcontrol/pull/7957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.79% <ø> (ø)` | | | [v4](https://app.codecov.io/gh/apache/trafficcontrol/pull/7957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.18% <ø> (ø)` | | | [v5](https://app.codecov.io/gh/apache/trafficcontrol/pull/7957/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.58% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.