search

apache / trafficcontrol

Apache Traffic Control is an Open Source implementation of a Content Delivery Network
https://trafficcontrol.apache.org/
Apache License 2.0
1.02k stars 339 forks source link

Updated node version from 18 to 20 #8009

Closed rimashah25 closed 1 month ago

rimashah25 commented 1 month ago

Upgrading node version to 20.11.0

## Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

Pass all GH actions

If this is a bugfix, which Traffic Control versions contained the bug?

N/A

PR submission checklist

zrhoffman commented 1 month ago

Looking at the end-to-end tests run (under Run everything and test):

  │ Cypress:        13.6.2                                                                         │
  │ Browser:        Electron 114 (headless)                                                        │
  │ Node Version:   v18.20.2 (/usr/local/bin/node)                                                 │

so it's still using Node 18 for the end-to-end tests, but it should use Node 20 instead.

rimashah25 commented 1 month ago

These titles:

https://github.com/apache/trafficcontrol/blob/03f7f149323cc22e4fe6fc63a064783f0d4c7c77/.github/workflows/tpv2.yml#L63

https://github.com/apache/trafficcontrol/blob/03f7f149323cc22e4fe6fc63a064783f0d4c7c77/.github/workflows/tpv2.yml#L96

https://github.com/apache/trafficcontrol/blob/03f7f149323cc22e4fe6fc63a064783f0d4c7c77/.github/workflows/tpv2.yml#L128

should be changed to

      - name: Node ${{ env.NODE_VERSION }}

Fixed in c44f5aa

zrhoffman commented 1 month ago

TPv2 still runs on Node 16 in CDN in a Box for Developers.

https://github.com/apache/trafficcontrol/blob/a89223526370e10b49ba26d0e302e1f3a4617374/dev/tpv2/Dockerfile#L26