search

apache / trafficcontrol

Apache Traffic Control is an Open Source implementation of a Content Delivery Network
https://trafficcontrol.apache.org/
Apache License 2.0
1.07k stars 344 forks source link

[TC-298] Health params.json updated with certain Profile names Github Issue #896 #910

Open limited opened 7 years ago

limited commented 7 years ago

Create Profile names in the Traffic_OPs with names such as Edge and Mid for Edge and Mid cache profiles, these don't get updated in the heath_params.json on the Traffic monitor.

In the current implementation of traffic ops, there is no "type" for a profile. When generating the health-params.json for traffic monitor, ops do not know which profile is for edge or middle or router, etc. So in traffic ops code, it use the convention that:
profile starting with "RASCAL" is a traffic monitor profile
profile starting with "CCR" is a traffic router profile
profile starting with "EDGE" is an edge server profile
profile starting with "MID" is a middle server profile

It is better to add a type for each profile, or make a restriction for the profile name.

Author: Dewayne Richardson JIRA Link: https://issues.apache.org/jira/browse/TC-298 Found Version: 2.1.0

mitchell852 commented 6 years ago

profiles have types now but that doesn't address the issue of keying off of profile type rather than profile name convention. I think this is tech debt.