bneradt
commented
1 year ago Here's this at frame 3:
(gdb) f 3
#3 Http2ConnectionState::_get_configured_initial_window_size (this=0x7f6da49a7310) at ../../../../../../_scm/trafficserver10.0/proxy/http2/Http2ConnectionState.cc:1101
1101 Http2ConnectionState::_get_configured_initial_window_size() const
(gdb) p *this
$5 = {
<Continuation> = {
<force_VFPT_to_top> = {
_vptr.force_VFPT_to_top = 0x8a4248 <vtable for Http2ConnectionState+16>
},
members of Continuation:
handler = (int (Continuation::*)(Continuation * const, int, void *)) 0x630270 <Http2ConnectionState::state_closed(int, void*)>,
mutex = {
m_ptr = 0x7f6d57177b40
},
link = {
<SLink<Continuation>> = {
next = 0x0
},
members of Link<Continuation>:
prev = 0x0
},
control_flags = {
raw_flags = 0
},
thread_affinity = 0x0
},
members of Http2ConnectionState:
rx_error_code = {
cls = ProxyErrorClass::SSN,
code = 0
},
tx_error_code = {
cls = ProxyErrorClass::NONE,
code = 0
},
session = 0x7f6da49a7308,
local_hpack_handle = 0x7f6ca4586bb0,
peer_hpack_handle = 0x7f6ca4586de0,
dependency_tree = 0x0,
_cop = {
<Continuation> = {
<force_VFPT_to_top> = {
_vptr.force_VFPT_to_top = 0x8a6468 <vtable for ActivityCop<Http2Stream, DLL<Http2Stream, Continuation::Link_link> >+16>
},
members of Continuation:
handler = (int (Continuation::*)(Continuation * const, int, void *)) 0x63ecb0 <ActivityCop<Http2Stream, DLL<Http2Stream, Continuation::Link_link> >::check_activity(int, Event*)>,
mutex = {
m_ptr = 0x7f6d57177b40
},
link = {
<SLink<Continuation>> = {
next = 0x0
},
members of Link<Continuation>:
prev = 0x0
},
control_flags = {
raw_flags = 0
},
thread_affinity = 0x0
},
members of ActivityCop<Http2Stream, DLL<Http2Stream, Continuation::Link_link> >:
_event = 0x7f6d570f9ac0,
_list = 0x7f6da49a7420,
_freq = 1
},
local_settings = {
settings = {4096, 0, 100, 65535, 16384, 131072}
},
acknowledged_local_settings = {
settings = {4096, 0, 100, 65535, 16384, 131072}
},
peer_settings = {
settings = {4096, 1, 100, 2097152, 16384, 4294967295}
},
static _frame_handlers = {(Http2Error (Http2ConnectionState::*)(Http2ConnectionState * const, const Http2Frame &)) 0x633d50 <Http2ConnectionState::rcv_data_frame(Http2Frame const&)>, (Http2Error (Http2ConnectionState::*)(Http2ConnectionState * const, const Http2Frame &)) 0x639a50 <Http2ConnectionState::rcv_headers_frame(Http2Frame const&)>, (Http2Error (Http2ConnectionState::*)(Http2ConnectionState * const, const Http2Frame &)) 0x63b2a0 <Http2ConnectionState::rcv_priority_frame(Http2Frame const&)>, (Http2Error (Http2ConnectionState::*)(Http2ConnectionState * const, const Http2Frame &)) 0x630f50 <Http2ConnectionState::rcv_rst_stream_frame(Http2Frame const&)>, (Http2Error (Http2ConnectionState::*)(Http2ConnectionState * const, const Http2Frame &)) 0x635520 <Http2ConnectionState::rcv_settings_frame(Http2Frame const&)>, (Http2Error (Http2ConnectionState::*)(Http2ConnectionState * const, const Http2Frame &)) 0x630b30 <Http2ConnectionState::rcv_push_promise_frame(Http2Frame const&)>, (Http2Error (Http2ConnectionState::*)(Http2ConnectionState * const, const Http2Frame &)) 0x631bb0 <Http2ConnectionState::rcv_ping_frame(Http2Frame const&)>, (Http2Error (Http2ConnectionState::*)(Http2ConnectionState * const, const Http2Frame &)) 0x630c40 <Http2ConnectionState::rcv_goaway_frame(Http2Frame const&)>, (Http2Error (Http2ConnectionState::*)(Http2ConnectionState * const, const Http2Frame &)) 0x638320 <Http2ConnectionState::rcv_window_update_frame(Http2Frame const&)>, (Http2Error (Http2ConnectionState::*)(Http2ConnectionState * const, const Http2Frame &)) 0x637db0 <Http2ConnectionState::rcv_continuation_frame(Http2Frame const&)>},
stream_list = {
<DLL<Http2Stream, Continuation::Link_link>> = {
head = 0x0
},
members of Queue<Http2Stream, Continuation::Link_link>:
tail = 0x0
},
latest_streamid_in = 31,
latest_streamid_out = 0,
stream_requests = {
<std::__atomic_base<int>> = {
static _S_alignment = 4,
_M_i = 16
},
members of std::atomic<int>:
static is_always_lock_free = true
},
peer_streams_count_in = {
<std::__atomic_base<unsigned int>> = {
static _S_alignment = 4,
_M_i = 0
},
members of std::atomic<unsigned int>:
static is_always_lock_free = true
},
peer_streams_count_out = {
<std::__atomic_base<unsigned int>> = {
static _S_alignment = 4,
_M_i = 0
},
members of std::atomic<unsigned int>:
static is_always_lock_free = true
},
total_peer_streams_count = {
<std::__atomic_base<unsigned int>> = {
static _S_alignment = 4,
_M_i = 0
},
members of std::atomic<unsigned int>:
static is_always_lock_free = true
},
stream_error_count = 0,
_peer_rwnd = 10285678,
_local_rwnd = 6553500,
_local_rwnd_is_shrinking = false,
_recent_rwnd_increment = {
_M_elems = {10485760, 18446744073709551615, 18446744073709551615, 18446744073709551615, 18446744073709551615}
},
_recent_rwnd_increment_index = 1,
_received_settings_counter = {
_vptr.Http2FrequencyCounter = 0x8a67c8 <vtable for Http2FrequencyCounter+16>,
_count = {2, 0},
_last_update = 1695409747
},
_received_settings_frame_counter = {
_vptr.Http2FrequencyCounter = 0x8a67c8 <vtable for Http2FrequencyCounter+16>,
_count = {2, 0},
_last_update = 1695409747
},
_received_ping_frame_counter = {
_vptr.Http2FrequencyCounter = 0x8a67c8 <vtable for Http2FrequencyCounter+16>,
_count = {0, 0},
_last_update = 0
},
_received_priority_frame_counter = {
_vptr.Http2FrequencyCounter = 0x8a67c8 <vtable for Http2FrequencyCounter+16>,
_count = {0, 0},
_last_update = 0
},
_outstanding_settings_frames = std::queue wrapping: std::deque with 0 elements,
continued_stream_id = 0,
_scheduled = false,
fini_received = true,
in_destroy = false,
recursion = 0,
shutdown_state = HTTP2_SHUTDOWN_NONE,
shutdown_reason = Http2ErrorCode::HTTP2_ERROR_NO_ERROR,
shutdown_cont_event = 0x0,
fini_event = 0x0,
zombie_event = 0x0
}
jpeach
github-actions[bot]
We noticed the following ATS 10 crash in production. It's a nullptr dereference that would come up every 10-30 minutes on a box running about 1,800 rps.
Backing out #9997 alleviates the crash.