Fail earlier if Netcat is not installed

apache / trafficserver

Apache Traffic Server™ is a fast, scalable and extensible HTTP/1.1 and HTTP/2 compliant caching proxy server.

https://trafficserver.apache.org/

Apache License 2.0

1.8k stars 798 forks source link

Fail earlier if Netcat is not installed #11438

Closed JosiahWI closed 3 months ago

JosiahWI commented 3 months ago

Some AuTests require Netcat as a client, but do not get skipped if it is missing. ~~This updates the tests so that they get skipped if Netcat is not installed.~~

EDIT: This updates CMakeLists.txt and autest.sh to fail appropriately if Netcat is missing.

JosiahWI commented 3 months ago

We may not want to merge this because it would cause CI to pass without indicating an issue if the nc command were missing, and we need those tests to run.

JosiahWI commented 3 months ago

I've repurposed the PR to have the CMake build and autest.sh check for netcat and fail if it is missing, rather than skipping tests based on its presence.