search

apache / trafficserver

Apache Traffic Server™ is a fast, scalable and extensible HTTP/1.1 and HTTP/2 compliant caching proxy server.
https://trafficserver.apache.org/
Apache License 2.0
1.74k stars 782 forks source link

Update magick plugin to OpenSSL 1.1.1 API #11441

Closed JosiahWI closed 2 weeks ago

JosiahWI commented 3 weeks ago

The functions EVP_MD_CTX_create and EVP_MD_CTX_destroy were renamed to EVP_MD_CTX_new and EVP_MD_CTX_free in OpenSSL 1.1.0. This renames them in the magick plugin accordingly. This also replaces the individual calls to EVP_DigestVerifyUpdate and EVP_DigestVerifyFinal with a single call to EVP_DigestVerify which is available in OpenSSL 1.1.1.

JosiahWI commented 3 weeks ago

LSan detected a leak in the magick plugin and the AuTest prefetch_simple failed:

   Run: 2-tr: Failed
     Starting TestRun 2-tr : No Issues found - Passed
        Reason: Started!
     Process: Default: Failed
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0
       file /tmp/sandbox/prefetch_simple/_output/2-tr-Default/stream.stdout.txt : Checking that /tmp/sandbox/prefetch_simple/_output/2-tr-Default/stream.stdout.txt matches prefetch_simple.gold - Failed
          Reason: File differences
           Gold File : /home/jenkins/workspace/Github_Builds/autest/src/tests/gold_tests/pluginTest/prefetch/prefetch_simple.gold
           Data File : /tmp/sandbox/prefetch_simple/_output/2-tr-Default/stream.stdout.txt
             GET http://domain.in/texts/demo-1.txt HTTP/1.1
             GET http://domain.in/texts/demo-2.txt HTTP/1.1
             GET http://domain.in/texts/demo-3.txt HTTP/1.1
           - GET http://domain.in/texts/demo-4.txt HTTP/1.1

Note: the leak report was different this time and didn't indicate libssl as the issue but rather an unknown module.

JosiahWI commented 3 weeks ago

LSan detected a leak in the magick plugin three more times.