search

apache / trafficserver

Apache Traffic Server™ is a fast, scalable and extensible HTTP/1.1 and HTTP/2 compliant caching proxy server.
https://trafficserver.apache.org/
Apache License 2.0
1.8k stars 798 forks source link

Fix last left unused parameters in the project #11471

Closed freak82 closed 3 months ago

freak82 commented 3 months ago

Fix unused parameters, using /* name ATS_UNUSED */, in mgmt and proxy and few others left here and there.

This pull request is ~the last~ part of the effort for removing the -Wno-unused-parameter warning suppression.

freak82 commented 3 months ago

I'm going to set back the warning suppression as there are more knobs which need to turned on to find all of the places which trigger this warning. I don't want to turn the CI into a sandbox for finding the next missing feature which I haven't enabled while building.

JosiahWI commented 3 months ago

The AuTest tls_sni_with_port failed.

Process: server2.wow.com: Failed
       Setting up : Copying '/home/jenkins/workspace/Github_Builds/autest/src/build/proxy-verifier-v2.10.1/linux-amd64' to '/tmp/sandbox/tls_sni_with_port/server2.wow.com/bin' - Passed
       Setting up : recycling port: 61178, queue size: 993 - Passed
       Setting up : recycling port: 61179, queue size: 992 - Passed
       Setting up : recycling port: 61180, queue size: 991 - Passed
       Setting up : Copying '/home/jenkins/workspace/Github_Builds/autest/src/tests/gold_tests/autest-site/../../tools/proxy-verifier/ssl/server.pem' to '/tmp/sandbox/tls_sni_with_port/server2.wow.com/server.pem' - Passed
       Setting up : Copying '/home/jenkins/workspace/Github_Builds/autest/src/tests/gold_tests/autest-site/../../tools/proxy-verifier/ssl/ca.pem' to '/tmp/sandbox/tls_sni_with_port/server2.wow.com/ca.pem' - Passed
       Setting up : Copying 'tls_sni_with_port.replay.yaml' to '/tmp/sandbox/tls_sni_with_port/server2.wow.com/tls_sni_with_port.replay.yaml' - Passed
       Test : Checking that ReturnCode == 0 - Passed
          Reason: Returned Value: 0 == 0
       Time-Out : Process finishes within expected time - Passed
          Reason: Returned value: 2.0000126361846924 < 600.0
       file /tmp/sandbox/tls_sni_with_port/_output/0-tr-server2.wow.com/stream.all.txt : request was remaped to server three - Failed
          Reason: Contents of /tmp/sandbox/tls_sni_with_port/_output/0-tr-server2.wow.com/stream.all.txt did not contains expression: "Received an HTTP/1 Content-Length body of 16 bytes for key conn_remapped"
JosiahWI commented 3 months ago

The AuTest proxy_protocol failed.

freak82 commented 3 months ago

Thanks. I was hoping initially that these will be the last changes needed. However, it turned out that I'm missing some build knobs which enable certain features/subsystems. I need to figure out all of the possible build knobs, to enable them explicitly and cleanup the last standing unused parameters.

JosiahWI commented 3 months ago

The main ones are probably building with QUIC enabled (requires an alternate SSL implementation, tools/build_h3_tools can build that stuff) and making sure all plugins are built (some are turned off if dependencies are missing).

JosiahWI commented 3 months ago

A very useful technique for debugging build configurations is to use the CI presets, for example: cmake --preset ci-rocky. This should enable all the same knobs used in the Rocky CI. But this will still skip some experimental plugins I think if dependencies are missing, and you'll need to have run the h3_build_tools script so that custom-built dependencies are installed in the right locations where it expects them.

freak82 commented 3 months ago

That's really useful. Thank you.

cmcfarlen commented 3 months ago

Cherry-picked to v10.0.x