Fix unused parameters in `proxy/http3` functionality

apache / trafficserver

Apache Traffic Server™ is a fast, scalable and extensible HTTP/1.1 and HTTP/2 compliant caching proxy server.

https://trafficserver.apache.org/

Apache License 2.0

1.74k stars 781 forks source link

Fix unused parameters in `proxy/http3` functionality #11482

Closed freak82 closed 3 days ago

freak82 commented 4 days ago

Fix unused parameters using /* name ATS_UNUSED */

This pull request is part of the effort for removing the -Wno-unused-parameter warning suppression.

JosiahWI commented 3 days ago

I think this needs to be updated at the calling site as well.

freak82 commented 3 days ago

You are right. I should have left these changes for tomorrow. To do them on a clear head. I'm about to fix it. And the other pull request is probably broken too.

JosiahWI commented 3 days ago

The AuTest chunked_encoding_disabled failed.

           -       [DEBUG]: Response connection: keep-alive
           +       [DEBUG]: Response contained "Connection: close". Closing the connection for key: 1.
           +       [DEBUG]: Reading response header.
           +       [DEBUG]: Received an HTTP/1 200 response for key 2 with headers:

cmcfarlen commented 3 days ago

Cherry-picked to v10.0.x