search

apache / trafficserver

Apache Traffic Server™ is a fast, scalable and extensible HTTP/1.1 and HTTP/2 compliant caching proxy server.
https://trafficserver.apache.org/
Apache License 2.0
1.74k stars 781 forks source link

Remove the `-Wno-unused-parameter` warning suppression #11489

Closed freak82 closed 3 days ago

freak82 commented 3 days ago

This removes the -Wno-unused-parameter warning suppression from the main CMakeLists.txt of the project.

I built the project with different presets: ci-debian, ci-ubuntu, ci-rocky, ci-clang-analyzer with GCC 13.2. Also built it with Clang 17. Built it in both debug and release modes.

Seems like the warning is no longer needed. Let's see if I'm missing something.

This pull request is hopefully the final part of the effort for removing the -Wno-unused-parameter warning suppression.

JosiahWI commented 3 days ago

@freak82 As I cautioned about earlier, some experimental plugins are skipped if dependencies are missing. It looks like those are the remaining culprits. CMake should print a report at the end of its configuration showing which plugins are on or off, and you can enable the ones that are off (e.g. -DENABLE_MAXMIND_ACL=ON) to require them so that CMake tells you which dependencies are missing. But off the top of my head, the dependencies include at least maxmind_acl libmaxminddb, libcjose, and a version of NuRaft with CMake integration.

freak82 commented 3 days ago

Understood. I'll close this pull request as the things are not ready yet.

JosiahWI commented 3 days ago

Feel free to re-open it with the remaining fixes once they're ready. I think we'll be able to remove the warning suppression after the experimental plugins are fixed.