pcre library needs to be upgrade to pcre2

apache / trafficserver

Apache Traffic Server™ is a fast, scalable and extensible HTTP/1.1 and HTTP/2 compliant caching proxy server.

https://trafficserver.apache.org/

Apache License 2.0

1.82k stars 804 forks source link

pcre library needs to be upgrade to pcre2 #8780

Open c-taylor opened 2 years ago

c-taylor commented 2 years ago

Current issues are:

pcre library is no longer maintained; author working on pcre2
pcre jit support in ATS is incomplete
- https://issues.apache.org/jira/browse/TS-3143
- https://issues.apache.org/jira/browse/TS-3144
Precompilation is not consistently implemented
Library review
- Should probably look at pcre2/je2 (or others)

Whilst looking at some high RPS rate tests libpcre was starting to 'feature' in traces. The obvious optimisation for libpcre is to use the jit support, which probably lends itself well to constrained lists of regex.

However, given the lack of maintenance on the current library an "architectural review" is probably required before more effort is spent...

c-taylor commented 2 years ago

It looks like trafficserver has an inconsistent approach: It precompiles the expressions, replacing the need/benefit of the jit in header_rewrite, but elsewhere makes no attempt.

Perhaps someone can confirm…

jeredfloyd commented 2 years ago

There is a new Fedora tracking bug for this issue: https://bugzilla.redhat.com/show_bug.cgi?id=2128391

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

maskit commented 1 year ago

Just to tell the bot this is not stale, we are going to do this by version 10.0 release.

bgermann commented 10 months ago

On the corresponding Debian bug, there is a patch available.

kenballus commented 1 month ago

libpcre3-dev has been removed from the Trixie repositories, so trafficserver can no longer be built on Debian testing.