search

apache / trafficserver

Apache Traffic Server™ is a fast, scalable and extensible HTTP/1.1 and HTTP/2 compliant caching proxy server.
https://trafficserver.apache.org/
Apache License 2.0
1.8k stars 796 forks source link

Errors in Diags::set_std_output() ignored, which can result in a crash. #9327

Open ywkaras opened 1 year ago

ywkaras commented 1 year ago

I ran a stress test that exhausts the available file descriptors for the traffic_server process. This caused the Diags::stdout_log member of Diags to be set to nullptr by this line: https://github.com/apache/trafficserver/blob/1426a069efc54f8096159473e3e4aafc3f23a0b4/src/tscore/Diags.cc#L791 , which then resulted in a segment violation. set_std_output() returns true/false to indicate whether a this or other errors occurred, but this return value is ignore. Maybe the errors in this function should simply cause a FATAL TS error

github-actions[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

ywkaras commented 8 months ago

Still an issue.