search

apache / tsfile

Apache TsFile
https://tsfile.apache.org/
Apache License 2.0
105 stars 50 forks source link

feature/unittests #134

Closed 761417898 closed 5 months ago

761417898 commented 5 months ago

The unit test framework chosen is GTest(https://github.com/apache/tsfile/issues/111#issuecomment-2165917872), as recommended by Chris. The unit tests have been implemented for the common utils file encoding section.

ColinLeeo commented 5 months ago

Excellent job. Google Test is a good choice for verification testing in C/C++. However, it seems there is still an issue with the POM configuration.

ColinLeeo commented 5 months ago

LGTM

ColinLeeo commented 5 months ago

The C++ 14 version is actually a bit high; we should at least support up to C++ 11. Google Test might only support C++ 14 after a certain version, so perhaps we should adjust the version of Google Test.

The test is compiled using C++ 14, but the code is written in C++ 11, which may lead to some errors.

761417898 commented 5 months ago

The C++ 14 version is actually a bit high; we should at least support up to C++ 11. Google Test might only support C++ 14 after a certain version, so perhaps we should adjust the version of Google Test.

The test is compiled using C++ 14, but the code is written in C++ 11, which may lead to some errors.

I have updated the version of GTest. V0.12 is the latest version with support for C++11

761417898 commented 5 months ago

The issues pointed out by the review have been fixed, are we ready to prepare for the merge? @jt2594838