apache / tvm

Open deep learning compiler stack for cpu, gpu and specialized accelerators
https://tvm.apache.org/
Apache License 2.0
11.76k stars 3.47k forks source link

[Tracking Issue] Refactor AOT executor codegen into IRModule -> IRModule form #12548

Closed mbaret closed 1 month ago

mbaret commented 2 years ago

The AOT executor codegen has accumulated significant technical debt and dead code during its development, resulting in a component that is difficult to understand, test and extend. Refactoring it will improve code-quality and make it easier to introduce new features to expand the capabilities of AOT code generation.

This refactor aims to observe the following principles:

PRs

ekalda commented 1 year ago

@areusch @mbaret is there a plan to continue this work? It looks like it's stuck in an awkward place where there is some duplicated code and a set of functions that are not used outside of the tests :)

mbaret commented 1 year ago

It's not my intention to continue with this refactor, I've instead been working on a Relax version of AOT. To avoid duplication, I could migrate the necessary passes to the unity branch and delete them from main. Let me know if this is the preferred course of action or whether there's any community interest in picking this refactor up.

ekalda commented 1 year ago

Yes, I don't think the efforts to prototype Relax should justify bringing technical dept into TVM, so it would be better to remove the duplicated code. I don't think it is blocking anybody though, so it's not urgent.