apache / tvm

Open deep learning compiler stack for cpu, gpu and specialized accelerators
https://tvm.apache.org/
Apache License 2.0
11.82k stars 3.48k forks source link

Compiled with Default Target(LLVM) and Built with USE_MRVL=ON #17455

Closed MNGanesan closed 1 month ago

MNGanesan commented 1 month ago

Please review the fix:

It is a unique use-case to check the default target(LLVM), though TVM is built with BYOC(MRVL-ON) The config of Codegen(BYOC) contains default values for configuration/optons, it is extracted during _generate_codegen_args. In command line processing, validate_target_args checks if there are add-on options and it expects that particular target to be given explicitly in command line. Here, it is test for default (LLVM) path only, hence validate_target_args need to ignore the codegen's configuration

MNGanesan commented 1 month ago

@Hzfengsy @lhutton1

Could you please review this patch ?

Thanks

Hzfengsy commented 1 month ago

cc TVMC maintainer @leandron

MNGanesan commented 1 month ago

@leandron

Please review my updated patch which has generic fix., The purpose of this fix is not to extract any options of codegen(BYOC) when only default target is specified by the user.

Eg: python3 -m tvm.driver.tvmc compile --target="llvm" model.onnx

Thanks

MNGanesan commented 1 month ago

@leandron

Could you please merge this PR?

Thanks

leandron commented 1 month ago

@leandron

Could you please merge this PR?

Thanks

Yes, I just forgot this step after the review. This is merged now - thanks for your PR.

MNGanesan commented 1 month ago

@leandron

Thanks a lot for your quick review feedback and response.