Closed MNGanesan closed 1 month ago
@Hzfengsy @lhutton1
Could you please review this patch ?
Thanks
cc TVMC maintainer @leandron
@leandron
Please review my updated patch which has generic fix., The purpose of this fix is not to extract any options of codegen(BYOC) when only default target is specified by the user.
Eg: python3 -m tvm.driver.tvmc compile --target="llvm" model.onnx
Thanks
@leandron
Could you please merge this PR?
Thanks
@leandron
Could you please merge this PR?
Thanks
Yes, I just forgot this step after the review. This is merged now - thanks for your PR.
@leandron
Thanks a lot for your quick review feedback and response.
Please review the fix:
It is a unique use-case to check the default target(LLVM), though TVM is built with BYOC(MRVL-ON) The config of Codegen(BYOC) contains default values for configuration/optons, it is extracted during _generate_codegen_args. In command line processing, validate_target_args checks if there are add-on options and it expects that particular target to be given explicitly in command line. Here, it is test for default (LLVM) path only, hence validate_target_args need to ignore the codegen's configuration