search

apache / uima-uimacpp

C++ support for Apache UIMA
https://uima.apache.org/
Apache License 2.0
15 stars 19 forks source link

Bulk update to C++-17 #1

Closed dgruhl closed 5 years ago

dgruhl commented 5 years ago

The last attempt to split out the commits didn't work so here is a bulk update to C++-17 for discussion.

The big changes are:

Putting unicode string into the icu namespace auto_ptr->unique_ptr added a virtual destructor to a base class that needed to (and fixed all the bugs that resulted) a bunch of things like char is a signed value, in code strings are const, etc. tempfile creation updated move to standard map and set in stl A really insidious bug in the sax interface where the wrong type was used plus over all cleaning pass

eaepstein commented 5 years ago

Tested these changes on RHEL 7.7 machine with compile option -std=c++11. c++14/c++17 were not compatible with the version of Xerces-C pulled from the RHEL 7 repo.