search

apache / uima-uimacpp

C++ support for Apache UIMA
https://uima.apache.org/
Apache License 2.0
15 stars 19 forks source link

Write GH actions to produce docker image #12

Open DrDub opened 6 months ago

DrDub commented 6 months ago

The Docker images for UIMACPP should be generated using GitHub Actions.

tmjoris commented 5 months ago

@DrDub I closed the previous PRs and I created a more efficient GH actions file Screenshot from 2024-04-17 04-37-51

I just wanted to clarify it would be okay if it builds an image each time there's a push and a new PR is created

DrDub commented 3 months ago

Hi @tmjoris . Thanks for your help and interest in contributing to Apache UIMA!

For the record, this is the past commit where you put together a GH actions file: https://github.com/apache/uima-uimacpp/pull/16/commits/e825f127ae69b528db2a77b6bb68b92d37202f6a

I did look at it, it looks it should do what we want. Now, it contains much reduplication from the Dockerfile. Is there any way to reuse the Dockerfile in there so we don't need to update both places every time something changes?

DrDub commented 3 months ago

I just wanted to clarify it would be okay if it builds an image each time there's a push and a new PR is created

Very good question. Running tests will make sense on each push and new PR. But building the image might be overkill. On the other hand, this project is low traffic.

I also wonder how many GH Actions credits does the foundation receives as part of its membership.

reckart commented 3 months ago

Maybe this helps:

https://infra.apache.org/github-actions-policy.html

DrDub commented 3 months ago

Maybe this helps:

https://infra.apache.org/github-actions-policy.html

This is fantastic. I tried finding something like this with Google with no avail. Thanks so much!

tmjoris commented 3 months ago

Hey @DrDub, I realized the first GitHub actions file was inefficient and not compliant with industry standards. So I made some modifications to immensely reduce the time it took to build an image.

I also came to realize that it may be a good idea for a new image to be built each we plan on making a new release which has either new features or significant bug fixes.

However, I've also realized that if we're to publish the image to the GitHub registry I would need to add a login sequence to the actions file, which was not present before. To do that, we would need to follow the standards highlighted in the policy file @reckart sent earlier.

I will update all of you soon on the progress.

reckart commented 3 months ago

@tmjoris I am curious what changes you made. Could you open a PR draft so they become visible?