search

apache / www-site

The ASF Website
Apache License 2.0
46 stars 108 forks source link

Home page title has the word 'test' #356

Closed nachovalera closed 6 months ago

nachovalera commented 6 months ago

https://www.apache.org/#software-for-the-public-good-test I created a PR removing it as this was likely unintentional.

355

Xuanwo commented 6 months ago

This PR https://github.com/apache/www-site/pull/354 has been merged by the author without review. I believe we should establish a basic approval requirement to avoid this.

tisonkun commented 6 months ago

IIRC foundation wise repos adopt commit then review process. We find issue and fix; it should be fine.

tisonkun commented 6 months ago

Resolved by https://github.com/apache/www-site/issues/356.

Xuanwo commented 6 months ago

IIRC foundation wise repos adopt commit then review process. We find issue and fix; it should be fine.

Fine.

bproffitt commented 6 months ago

Except www-site content needs to be approved by M&P, and no such review was conducted by us. So, not really fine as an approach. In this case, the change was minimal, but it would be great to wait for M&P review/merging.

tisonkun commented 6 months ago

@bproffitt Good to know. If there are active reviewers (M&P, as you said) in this repo, then it's good to wait for reviews. I'll keep this in mind and tell others when found.

tisonkun commented 6 months ago

Perhaps we can add a sentence in the README file, as I declare that the other foundation-wise repo "apache-website-template" is "maintained by the COMDEV PMC" - https://github.com/apache/apache-website-template?tab=readme-ov-file#contact-us

sebbASF commented 6 months ago

@tisonkun I suggest you raise a PR (or an ISSUE) against the README file; this issue is closed