search

apache / www-site

The ASF Website
Apache License 2.0
42 stars 97 forks source link

Update board policies overview page #362

Closed ShaneCurcuru closed 3 months ago

ShaneCurcuru commented 3 months ago

This removes the draft marker and cleans up pointers to any well-recognized MUST links, which include some sort of board or specific policy-setting officer policy on them, versus some SHALL/MAY links which are best practices or similar.

jerpelea commented 3 months ago

do we need the merge commit ?

ShaneCurcuru commented 3 months ago

Apologies - if someone can lead me through using GitHub Desktop to avoid the merge commit, I will definitely clean up PRs in the future! Thanks all.

sebbASF commented 3 months ago

AFAICT the PR is squashed when it is applied to the target repo, so why is it necessary to avoid such commits in the repo that is the source for the PR?

tisonkun commented 3 months ago

@sebbASF as far as I can see in the commit history https://github.com/apache/www-site/commits/main/

We're using the Merge Commit strategy so it's not squashed.

sebbASF commented 3 months ago

Surely that depends on how the PR is applied?

It's normally possible to squash at time of merge.

tisonkun commented 3 months ago

@sebbASF Sure. I point out that this is not the case for this repo. We can retain only the squash and commit option with .asf.yaml, or spread the knowledge among committers so that they make decisions case by case.

https://github.com/apache/opendal/blob/71bddb4e3050641c2cf5897cdb7591e9787c93bb/.asf.yaml#L30-L33

sebbASF commented 3 months ago

In what way is it not the case? If you look at PR #334 that has more than 1 commit, and Squash and Merge is enabled.

If there is an issue with .asf.yaml then raise a PR for it.