search

apainintheneck / crystal-linenoise

Crystal bindings for the Linenoise library
https://apainintheneck.github.io/crystal-linenoise/
MIT License
1 stars 0 forks source link

Add command line history tests #20

Closed apainintheneck closed 8 months ago

apainintheneck commented 8 months ago

I realized that this was something that could be tested in a relatively straightforward manner without needing an interactive console session.

apainintheneck commented 8 months ago

Closes #16.

apainintheneck commented 8 months ago

I'm not entirely sure why this would be failing right now on Linux but it seems like there is some sort of problem loading lines from a file. Nothing seems out of the ordinary here code wise so I'll have to do a bit more digging to figure it out. Interestingly enough, there are no problems on macOS.

apainintheneck commented 8 months ago

I was able to pull in this PR from a few years ago and that fixed all of the problems. I think the problem was that it was missing the string headers and that caused problems with strdup but I'm not entirely sure.

Thanks @emvigo for that PR from 5 years ago! It was a big help.