apal21 / nextjs-progressbar

A simple Next.js progressbar component using NProgress.
https://www.npmjs.com/package/nextjs-progressbar
MIT License
776 stars 61 forks source link

feat: minor changes #59

Closed imranbarbhuiya closed 2 years ago

imranbarbhuiya commented 2 years ago

All the changes

imranbarbhuiya commented 2 years ago

I'm planning to add an example folder, what say?

Also, I'll be updating the nextjs to 12.0.2 in dev deps as soon as it released. Because v12.0.0 is showing few errors in npm install which is fixed in nextjs v12.0.2-canary.4.

imranbarbhuiya commented 2 years ago

@apal21 Also a suggestion to add husky and lint-staged.

imranbarbhuiya commented 2 years ago

All the changes

@apal21 here's complete change log, please review

One thing left is updating to next v12.0.2 to remove all the warnings in npm install which isn't released yet.

imranbarbhuiya commented 2 years ago

I've a question also why the version name is like this and not 1.0.0? Just asking 😃.

apal21 commented 2 years ago

Thanks a lot for putting in so much effort. Really appreciate that.

why the version name is like this and not 1.0.0?

When I published this package, I didn't know that people are actually going to use it. So just for testing, I started releasing from v0.0.1 to learn how to publish a package and what to do next.

After 3-4 months, I realized that a lot of people are using this package. Since all the changes are backward compatible and if someone has already installed these versions, they won't get the new update even if it is not causing any issues. Hence, I continued with v0.0.x

imranbarbhuiya commented 2 years ago

I continued with v0.0.x

Got you.

And thank you for this awesome package ❤️.

imranbarbhuiya commented 2 years ago

Why your readme isn't showing in npm?

imranbarbhuiya commented 2 years ago

Here we go. I've updated to next v12.0.2 which have removed all the warning showing during npm intall.

@apal21 Review my changes. I hope everything is perfect and there is no breaking changes.

For this pr, this is the last commit. I'll definitely open more PRs if I find anything which can be improved or changed. Let me know if you want me to remove anything which I've added.

This PR doesn't change any core codes. It's more focused on DX.

I'm resending a complete change log of this PR.

imranbarbhuiya commented 2 years ago

Changelog

apal21 commented 2 years ago

Hey, since you are putting a lot of effort here and I am not getting enough time to work on this, would you like to be a collaborator for this repo?

imranbarbhuiya commented 2 years ago

Yeah, sure. Thank you for the opportunity.

apal21 commented 2 years ago

Done. Check your email.