feat: Rewritten both opened pull requests

apal21 / nextjs-progressbar

A simple Next.js progressbar component using NProgress.

https://www.npmjs.com/package/nextjs-progressbar

MIT License

776 stars 61 forks source link

feat: Rewritten both opened pull requests #62

Closed imranbarbhuiya closed 2 years ago

imranbarbhuiya commented 2 years ago

I've rewritten both the opened pull requests

[x] #50
[x] #45
[x] updated types and readme
[ ] didn't update change log and version

But I'm not getting a way to test them out. Can you make a beta release of this pr, so that I can test it.

imranbarbhuiya commented 2 years ago

I didn't tested the changes. Make a beta release so that I can test this out. I didn't change version or change log.

This release adds two new features

auto complete for advanced options
nonce support

So we can make a minor release as advised in semver.

apal21 commented 2 years ago

Did you try with npm link locally?

imranbarbhuiya commented 2 years ago

Functional component is showing some error related to hook. I'm not able to fix it. Problem is babel is adding useEffect inside of return, which isn't valid, so I'm going to add nonce only for now.

apal21 commented 2 years ago

Okay cool

imranbarbhuiya commented 2 years ago

I'm using npm link for the first time, and It seems like it's showing errors in the stable release also. I tried with the previous version which is working fine when installing with npm install but trowing errors when using link.