search

apal21 / nextjs-progressbar

A simple Next.js progressbar component using NProgress.
https://www.npmjs.com/package/nextjs-progressbar
MIT License
776 stars 61 forks source link

React 18 dependency #76

Open kkallasm opened 2 years ago

kkallasm commented 2 years ago

Doesn't support react version 18.

Chemchu commented 2 years ago

+1

frei-x commented 2 years ago

+2

Abdulrahmanelheyb commented 2 years ago

+3

imranbarbhuiya commented 2 years ago

Can you please provide the error and minimal reproducible code sample? I'm using it with react 18 in my project and it's working fine.

davidthomasparks commented 2 years ago

Mine doesn't seem to show the bar for a reasonable amount of time when using dynamic hrefs for Next/link not sure if anyone else has similar behavior on React 18

XanderSelorm commented 2 years ago

Mine doesn't seem to show the bar for a reasonable amount of time when using dynamic hrefs for Next/link not sure if anyone else has similar behavior on React 18

You're not alone. I face the same issue too.

imranbarbhuiya commented 2 years ago

Mine doesn't seem to show the bar for a reasonable amount of time when using dynamic hrefs for Next/link not sure if anyone else has similar behavior on React 18

Do you've any repository which reproduces this issue or can U provide a minimal code sample so I can test it?

davidthomasparks commented 2 years ago

I apologize @imranbarbhuiya I don't have enough time to set this up, but the issue for our app seems to be passing in an href to a child component that implements the prop in a Next/llink as an href. So a dynamic href passed into a child component.