search

apaleo / announcements

Subscribe to this repo to be notified about changes in the apaleo API
15 stars 1 forks source link

[03.11.2021] Introducing folio debitor type #88

Open dario-hd opened 3 years ago

dario-hd commented 3 years ago

In order to be able to distinguish who pays for what, we are introducing the debitor type on the folio with the following allowed values: Booker, PrimaryGuest, AdditionalGuest, Company. In addition, the Property debitor type value is reserved for house folios and cannot be used.

If your integration is POSTing or PATCHing folios and is setting debitor data, you should adjust it so that you also set the debitor type. For clarification, consider the following example:

Booker: Jon Doe Primary guest: Jane Doe Debitor: Jon Doe (type Booker)

If you want to make the primary guest the debitor of the folio, then you would need to change the debitor data to Jane Doe and, in addition, also set the debitor type to PrimaryGuest.

NOTE: The debitor type field is not yet mandatory, but it's going to be mandatory from 03.11.2021. If affected, you should adjust your integration before that date or your requests for POSTing or PATCHing folios will fail.

simone-montemezzani-3AP commented 3 years ago

Hi @dario-hd ,

I was investigating the impacts of this change on our project. Could you please provide a migration endpoint to migrate all existing Folios with null debitor.type to a valid TypeEnum value (as input)?

This is anyway what we would be implementing to handle this change (in addition to ensuring we populate the field when creating new Folios) The alternative would be to identify all points in the sourcebase where we do a PATCH of folios. But this has the drawback that we would not notice if we're missing the change somewhere; since until 03.11 we will not notice any errors and after 03.11 it will be too late... Unless you have a better suggestion?

Best regards, Simone

dario-hd commented 3 years ago

Hi @simone-montemezzani-3AP,

I'm not sure I understand your question correctly. How would the migration endpoint help you with this? You would still need to go through the codebase and adjust the POST and PATCH calls, or?

If you want we can take this conversation offline, feel free to reach out directly.

D.

RudolfBom59 commented 2 years ago

We got an Announcement on this issue today. As we are creating external folios through the API, is this change also for us?

Best, Rudolf Bom - Auriga Informatik GmbH, Effretikon, Switzerland.