search

apalfrey / select2-bootstrap-5-theme

A Select2 v4 theme for Bootstrap 5
https://apalfrey.github.io/select2-bootstrap-5-theme/
MIT License
218 stars 48 forks source link

Update _dropdown.scss #50

Closed Pixelshaped closed 3 years ago

Pixelshaped commented 3 years ago

Fixes #49 .

As the new z-index default in Bootstrap5 for a modal is 1055 (instead of 1050), the z-index for the dropdown should be 1056 (instead of 1051). Currently this default 1051 value is handled in the select2 main repository (https://github.com/select2/select2/blob/develop/src/scss/_dropdown.scss), which shouldn't change to stay compatible with Bootstrap4. Hence that PR in this project.

florianlacreuse commented 3 years ago

Will this patch be merged soon? Thanks!

Pixelshaped commented 3 years ago

@apalfrey sorry to ping you but we have no merging rights and this PR fixes an important issue. Thanks :)

In the meantime I compile my bootstrap SCSS files with these values:

// We should be able to remove those tweaks to the z-index following the merge of
// This PR: https://github.com/apalfrey/select2-bootstrap-5-theme/pull/50
$zindex-modal-backdrop:             1049 !default;
$zindex-modal:                      1050 !default;
apalfrey commented 3 years ago

@Pixelshaped Apologies, I've been pretty swamped from work for a while now 😐 It’s clearing up now so I actually have some time to work on this.

I'll get this sorted tomorrow and run a release, probably start on all the other things I'm wanting to do with this too!