search

apalfrey / select2-bootstrap-5-theme

A Select2 v4 theme for Bootstrap 5
https://apalfrey.github.io/select2-bootstrap-5-theme/
MIT License
217 stars 48 forks source link

Default font for controls inherited from bootstrap settings #6

Closed f1mishutka closed 3 years ago

f1mishutka commented 3 years ago

Changed font settings to $s2bs5-font-family: inherit !default;

We use custom font for bootstrap controls. So when use your original default value ($font-family-sans-serif) all select2 controls look different.

I think it would be much more cleaner to inherit default font from bootstrap settings. If someone want to override it it can be done by changing this variable before including this theme.

apalfrey commented 3 years ago

Looks good to me, doesn't seem to affect styling or anything! I'll go ahead and re-compile when I do a version bump

f1mishutka commented 3 years ago

And one more thank you! :)