adds windows compatibility

apas / athena

Minimalist static blog generator written in Python

https://apas.github.io/athena/

341 stars 23 forks source link

adds windows compatibility #11

Closed lordgrenville closed 5 years ago

lordgrenville commented 5 years ago

Some of us poor schmucks want to have beautiful websites even on Windows. Makes two small tweaks to the install script, based on how virtualenv handles Windows.

apas commented 5 years ago

While Windows compatibility is welcome, this breaks existing compatibility with macOS and other Unix-based systems. You need to wrap the changed functionality around a platform identifier and then run both accordingly.

lordgrenville commented 5 years ago

Yes, I only thought about that after submitting. Fixed it here; and to be on the safe side, tested it successfully on both a Mac and a PC.

apas commented 5 years ago

Tested successfully on macOS 10.14.3 and Pandoc 2.7. I don't have a PC so I'll take your word for it. Will merge.