DeadChest dropping a ton of times when expired.

[paddymadge]

Context

• Plugin version 4.8.1
• Minecraft version 1.18.1
• Server type (Bukkit/Spigot/Paper...) Paper / Purpur

Describe the bug Whenever someone dies, and their DeadChest expires it drops so many times that there are so many entities that when the chunk gets loaded, the server crashes or the TPS drops massively

To Reproduce Steps to reproduce the behavior:

1. Die with a full inventory
2. Make the chest expire

Note: This doesn't happen often. I don't know if it has to do with a DeadChest expiring in a unloaded chunk, but it made our server crash two times now to the point where I have to disable the plugin, sadly.

Screenshots (https://cdn.discordapp.com/attachments/913504551074664448/927276662620553326/unknown.png)

[CraftersX]

I confirm, it allows you to duplicate items https://i.imgur.com/hAgfGwg.png

[CraftersX]

DeadChest dropped items endlessly until we arrive!

[2022-01-21 21:42:53] New deadchest for [XANT3R] in world at X:-736 Y:94 Z:96 [2022-01-21 21:43:24] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:25] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:26] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:27] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:28] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:29] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:30] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:31] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:32] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:33] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:34] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:35] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:36] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:37] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:38] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:39] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:40] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:41] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:42] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:43] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:44] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:45] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:46] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:47] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:48] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:49] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:50] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:51] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:52] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:53] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:54] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:55] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:56] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:57] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:58] Deadchest of [XANT3R] has expired in world [2022-01-21 21:43:59] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:00] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:01] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:02] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:03] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:04] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:05] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:06] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:07] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:08] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:09] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:10] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:11] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:12] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:13] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:14] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:15] Deadchest of [XANT3R] has expired in world [2022-01-21 21:44:16] Deadchest of [XANT3R] has expired in world

Time instead of subtracting it adds

https://i.imgur.com/uNZnYCv.png

[paddymadge]

If you need a quick fix, I've set the deadchest timer to infinite temporarily, so it can't expire.

[CraftersX]

If you need a quick fix, I've set the deadchest timer to infinite temporarily, so it can't expire.

Just set it up "ItemsDroppedAfterTimeOut" to false ;x

[paddymadge]

works too.

[thekdub]

I also had this issue occur on my server (Paper 1.17.1 build 408, DeadChest 4.8.1). No errors in console, however I did get the same "Deadchest of [user] has expired in world" spam in my deadchest logs, as well as the items being duplicated on the ground.

That chest has since disappeared, however the text from it remains, and is stuck at 9m 21s remaining. No deadchests in the chestData folder either.

[apavarino]

Thanks for theses informations. I will work on a fix soon.

[apavarino]

Fixed on 4.8.2 ! Thanks a lot for your feedback. That was a great help

You can download it on discord or wait for bukkit validation staff