search

apavarino / Deadchest

Minecraft Plugin - Keep your inventory in a chest when you die !
https://dev.bukkit.org/projects/dead-chest
GNU General Public License v3.0
18 stars 17 forks source link

Decent Holograms support for the holograms bug #41

Closed Rectos28 closed 1 year ago

Rectos28 commented 2 years ago

Is your feature request related to a problem? As all knows about the holograms bug that they stay on the world even removing the plugin or removing the deadchest and the fix for the bug is annoying as I have to teleport to each bugged chest and remove the holograms one by one.

Describe the solution you'd like: By using holograms plugin as a dependency such as Decent Holograms we can eleminate the bug using there api to make the holograms and removing them.

broken1arrow commented 2 years ago

I don´t know how that will solve the issue. Because it is much deeper problem some cause this (he have added some fixes for this). You can read about it here, spigot have done a "fix" (not good fix for it but a fix). https://github.com/PaperMC/Paper/issues/5872

Rectos28 commented 2 years ago

From what I understand how the holograms is used in this plugin is that being as a vanilla entity. Using the holograms plugin as dependency will let the plugin handels everything from loading, unloding and deleting the holograms. Which will help fixing the issue.

broken1arrow commented 2 years ago

From what I understand how the holograms is used in this plugin is that being as a vanilla entity. Using the holograms plugin as dependency will let the plugin handels everything from loading, unloding and deleting the holograms. Which will help fixing the issue.

The issue is when try remove from unloaded chunks. I think only way is show the holos client side to remove the issue completely (don't know if Decent Holograms have this option).

apavarino commented 1 year ago

Fixed on last version