search

apavarino / Deadchest

Minecraft Plugin - Keep your inventory in a chest when you die !
https://dev.bukkit.org/projects/dead-chest
GNU General Public License v3.0
18 stars 17 forks source link

deadchest.log is beeing spammed with "Deadchest of [player] has expired in world" every second #61

Closed ShiruHD closed 8 months ago

ShiruHD commented 1 year ago

Context

Description When a player's deadchest is spawned, but the player disconnects, the log file is beeing overflown with the same massage "Deadchest of [player] has expired in world", until the player reconnects to the server.

To Reproduce Steps to reproduce the behavior:

  1. Die on Server with something in your inventory.
  2. Disconnect from Server.
  3. Wait for the duration wich is set for the expiration-time in the config. (Default: 5 mins)
  4. Look at the deadchest.log-file in the plugin folder. There you can see the spamming. (The file gets too big after some time!)
  5. After logging in the Server, the log file is no longer being written to about the expiration.

Expected behavior It should only be written once to the console that the deadchest is expired, regardless of the player being on the server or not.

Screenshots image The first yellow TimeStamp is when the player is still on the server the entire time, the second one is when the timer is expired when the player is offline.

apavarino commented 1 year ago

Thanks for the report !

apavarino commented 1 year ago

@ShiruHD I cannot reproduce. Did someone else is online on the server when you are offline ?

ShiruHD commented 1 year ago

Yes, it has to be someone else online during that time so the timer gets to

  1. I didn’t think about that when writing the report.

Arthur Pavarino @.***> schrieb am So. 23. Juli 2023 um 18:33:

@ShiruHD https://github.com/ShiruHD I cannot reproduce. Did someone else is online on the server when you are offline ?

— Reply to this email directly, view it on GitHub https://github.com/apavarino/Deadchest/issues/61#issuecomment-1646884203, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYBPMBLEUNDYLSNF6QVGGLDXRVG7LANCNFSM6AAAAAA2DB3WWY . You are receiving this because you were mentioned.Message ID: @.***>

apavarino commented 1 year ago

Alright thanks ! I already release the version 1.16.1 but I will work on that for the next one. Thanks again !