search

apavarino / Deadchest

Minecraft Plugin - Keep your inventory in a chest when you die !
https://dev.bukkit.org/projects/dead-chest
GNU General Public License v3.0
18 stars 17 forks source link

Items on 1.21 not stacking with other items #80

Open Mcklp opened 5 months ago

Mcklp commented 5 months ago

Items on 1.21 have different nbt data making them impossible to stack with other items

Describe the bug Items from deadchest have one additional component listed after hovering on them, making it impossible to stack with items that are not from deadchest. Using command "/data get entity @s SelectedItem" they have "minecrfat:damage": 0 (i added a photo). Despite that deadchest work for me on 1.21

To Reproduce Steps to reproduce the behavior:

  1. Get 2 same stackable items
  2. Get killed with one of it
  3. Pickup dead chest
  4. Try to stack them

Expected behavior Items from dead chest to be the same as the rest of the items.

Screenshots image

leshicodes commented 4 months ago

Not the Author, but If I am not mistaken I believe the highest supported version for this plugin is 1.20.6 right?

Mcklp commented 4 months ago

Yeah, thats right @leshicodes, but i wanted to write my observations to maybe help with updating it to 1.21. I know that this version isnt supported and thats why something like that happened. (I accidentally closed this thread sorry i reopened it)

leshicodes commented 4 months ago

@Mcklp very fair, and I had a feeling that's what your intentions were. I am a novice programmer so I might see if I can create a PR to support 1.21 unless the author disapproves.

apavarino commented 4 months ago

Hello, thanks for the report, it's a good help for me to provide a stable 1.21 version. I'm currently working on it. Stay tunned !

apavarino commented 4 months ago

Seems to be a paper issue. I made few tests, deadchest handle well item meta and NBT tags. But something is different from deachest block and game block. I compare values of ItemStack, this is strictly the same. i think it's something internal to the API. I will do more test when 1.21 Paper version will be more stable.