apavlenko / vmf

http://01org.github.io/vmf/
Apache License 2.0
0 stars 3 forks source link

'Compression' feature #10

Closed apavlenko closed 8 years ago

apavlenko commented 8 years ago

See #2 for details

savuor commented 8 years ago

@apavlenko , all your comments until this moment are fixed, please check the solutions

savuor commented 8 years ago

all comments until now fixed

apavlenko commented 8 years ago

VMF_User_guide.docx / Compression-custom: how to handle how to handle

a minor typo :)

savuor commented 8 years ago

all comments until that one are answered or fixed

savuor commented 8 years ago

all comments until now are answered or fixed @apavlenko please check new code

apavlenko commented 8 years ago

Here is an example of how should compressed metadata look inside a file:

      <rdf:Description rdf:about=""
            xmlns:xmp="http://ns.adobe.com/xap/1.0/"
            xmlns:vmf="http://ns.intel.com/vmf/2.0">
         <vmf:metadata>
            <rdf:Bag>
               <rdf:li rdf:parseType="Resource">
                  <vmf:schema>com.intel.vmf.compressed-metadata.v3</vmf:schema>
                  <vmf:set>
                     <rdf:Bag>
                        <rdf:li rdf:parseType="Resource">
                           <vmf:name>compressed-metadata</vmf:name>
                           <vmf:set>
                              <rdf:Bag>
                                 <rdf:li rdf:parseType="Resource">
                                    <vmf:id>0</vmf:id>
                                    <vmf:fields>
                                       <rdf:Bag>
                                          <rdf:li rdf:parseType="Resource">
                                             <rdf:value>some-algo-id</rdf:value>
                                             <vmf:name>algo-id</vmf:name>
                                          </rdf:li>
                                          <rdf:li rdf:parseType="Resource">
                                             <rdf:value>base64-data-string</rdf:value>
                                             <vmf:name>data</vmf:name>
                                          </rdf:li>
                                       </rdf:Bag>
                                    </vmf:fields>
                                 </rdf:li>
                              </rdf:Bag>
                           </vmf:set>
                        </rdf:li>
                     </rdf:Bag>
                  </vmf:set>
               </rdf:li>
            </rdf:Bag>
         </vmf:metadata>
         <vmf:schemas>
            <rdf:Bag>
               <rdf:li rdf:parseType="Resource">
                  <vmf:schema>com.intel.vmf.compressed-metadata.v3</vmf:schema>
                  <vmf:schema-author>VMF</vmf:schema-author>
                  <vmf:descriptors>
                     <rdf:Bag>
                        <rdf:li rdf:parseType="Resource">
                           <vmf:name>compressed-metadata</vmf:name>
                           <vmf:fields>
                              <rdf:Bag>
                                 <rdf:li rdf:parseType="Resource">
                                    <vmf:name>algo-id</vmf:name>
                                    <vmf:type>string</vmf:type>
                                 </rdf:li>
                                 <rdf:li rdf:parseType="Resource">
                                    <vmf:name>data</vmf:name>
                                    <vmf:type>string</vmf:type>
                                 </rdf:li>
                              </rdf:Bag>
                           </vmf:fields>
                        </rdf:li>
                     </rdf:Bag>
                  </vmf:descriptors>
               </rdf:li>
            </rdf:Bag>
         </vmf:schemas>
         <vmf:next-id>1</vmf:next-id>
      </rdf:Description>
apavlenko commented 8 years ago

in case of export to XML:

<?xml version="1.0"?>
<vmf nextId="1" filepath="" checksum="">
  <schemas-array>
    <schema name="com.intel.vmf.compressed-metadata.v3" author="VMF">
      <description name="compressed-metadata">
        <field name="algo-id" type="string"/>
        <field name="data" type="string"/>
      </description>
    </schema>
  </schemas-array>
  <metadata-array>
    <metadata schema="com.intel.vmf.compressed-metadata.v3" description="compressed-metadata" id="0">
      <field name="algo-id" value="some-algo-name"/>
      <field name="data" value="base64-string"/>
    </metadata>
  </metadata-array>
</vmf>

JSON:

{
  "vmf" : {
    "nextId" : 1,
    "filepath" : "",
    "checksum" : "",
    "schemas-array" : [
      {
        "name" : "com.intel.vmf.compressed-metadata.v3",
        "author" : "VMF",
        "descriptions-array" : [
          {
            "name" : "compressed-metadata",
            "fields-array" : [
              {
                "name" : "algo-id",
                "type" : "string"
              },
              {
                "name" : "data",
                "type" : "string"
              }
            ],
            "references-array" : []
          }
        ]
      }
    ],
    "metadata-array" : [
      {
        "schema" : "com.intel.vmf.compressed-metadata.v3",
        "description" : "compressed-metadata",
        "id" : 0,
        "fields-array" : [
          {
            "name" : "algo-id",
            "value" : "some-algo-id"
          },
          {
            "name" : "data",
            "value" : "base64-string"
          }
        ]
      }
    ]
  }
}
apavlenko commented 8 years ago

:+1:

apavlenko commented 8 years ago

:+1:

codecov-io commented 8 years ago

Current coverage is 64.08%

Merging #10 into vmf-3.0 will increase coverage by +1.08% as of 894e4f8

@@            vmf-3.0     #10   diff @@
=======================================
  Files            59      66     +7
  Stmts          6734    7030   +296
  Branches          0       0       
  Methods                           
=======================================
+ Hit            4243    4505   +262
  Partial           0       0       
- Missed         2491    2525    +34

Review entire Coverage Diff as of 894e4f8


Uncovered Suggestions

  1. +0.15% via ...f_MetadataStream.cpp#194...204
  2. +0.14% via ..._vmf_MetadataSet.cpp#402...411
  3. +0.13% via ...re/src/xmlwriter.cpp#223...231
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

savuor commented 8 years ago

:+1:

apavlenko commented 8 years ago

:+1:

coveralls commented 6 years ago

Coverage Status

Coverage increased (+29.09%) to 92.018% when pulling 82d410ae9b56fd94d8f44c3391d968e67584d0ec on rv/compression_prototype into 1082c5eea56278199f4d7d52ece8bab941776f50 on vmf-3.0.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-62.9%) to 0.0% when pulling 82d410ae9b56fd94d8f44c3391d968e67584d0ec on rv/compression_prototype into 1082c5eea56278199f4d7d52ece8bab941776f50 on vmf-3.0.