search

apavlenko / vmf

http://01org.github.io/vmf/
Apache License 2.0
0 stars 3 forks source link

VMF java wrappers #5

Closed anna-khakimova closed 8 years ago

anna-khakimova commented 8 years ago

solution for #1

NOTE: XML/JSON Readers aren't supported due to pending changes on C++ side, will be added a bit later.

apavlenko commented 8 years ago

I suggest you use debug logs in native code by the following way:

#if defined(DEBUG) || defined(_DEBUG)
  #include <stdio.h>
  #define LOGD(...) ((void)printf(__VA_ARGS__))
#else
  #define LOGD(...)
#endif
apavlenko commented 8 years ago

remove static function for C++ exceptions handling from header file, make it non-static.

codecov-io commented 8 years ago

Current coverage is 63.00%

Merging #5 into vmf-3.0 will decrease coverage by -16.30% as of 9cc1017

@@            vmf-3.0     #5   diff @@
======================================
  Files            36     59     +23
  Stmts          3716   6734   +3018
  Branches          0      0        
  Methods                           
======================================
+ Hit            2947   4243   +1296
  Partial           0      0        
- Missed          769   2491   +1722

Review entire Coverage Diff as of 9cc1017

Uncovered Suggestions

  1. +0.17% via ...f_MetadataStream.cpp#194...204
  2. +0.15% via ..._vmf_MetadataSet.cpp#402...411
  3. +0.14% via ...re/src/xmlwriter.cpp#223...231
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

apavlenko commented 8 years ago

:+1: code coverage will be restored as a part of the next VMF-3 task

apavlenko commented 8 years ago

install isn't implemented for Java API!

Please provide vmf_java.jar installation to install/java/. Also configure java sample to build from install/samples folder and use com.intel.vmf.sample package for the sample class. Most likely a kind of README is needed to help user configuring eclipse for building the sample project.

apavlenko commented 8 years ago

:+1: expect Android and desktop samples later ('samples update' task - not yet submitted) and expect coverage to be restored later ('improve coverage' task - #39)

anna-khakimova commented 8 years ago

:+1:

savuor commented 8 years ago

:+1: